Fixes for automatic recompilation of dependent functions #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Julia PR #17057 (the fix for issue #265) introduced some changes which made it invalid to call a function which was compiled after the call was compiled. This particular problem would occur when using the `apply` do-block. Note we could mostly avoid using `eval(Expr(:call, ...` if we force users to make a PatchEnv prior to using the apply do-block. Unfortunately this solution does not work with mocking a nested function and also is less user friendly.
Current coverage is 93.08% (diff: 100%)@@ master #10 diff @@
==========================================
Files 2 2
Lines 159 159
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 148 148
Misses 11 11
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Julia PR JuliaLang/julia#17057 (the fix for issue JuliaLang/julia#265) introduced some changes which made it invalid to call a function which was compiled after the function containing the call was compiled. This particular problem would occur when using the
applydo-block patching.